hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8483) HConnectionManager can leak ZooKeeper connections when using deleteStaleConnection
Date Mon, 06 May 2013 17:46:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649904#comment-13649904
] 

Eric Yu commented on HBASE-8483:
--------------------------------

[~ted_yu] The 0.94 branch passes tests locally with patch applied.
[~saint.ack@gmail.com] Oh, synchronizing on masterAndZKLock would be better and less confusing.
I didn't notice the change in synchronization from 0.94 to 0.95. In 0.94, synchronization
is on the getZooKeeperWatcher method and there wasn't a separate closeZooKeeperWatcher method.
I can modify the trunk patch. Maybe I can take out the synchronization I added to internalClose
if I move this.closed = true; before closeZooKeeperWatcher(). 
                
> HConnectionManager can leak ZooKeeper connections when using deleteStaleConnection
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-8483
>                 URL: https://issues.apache.org/jira/browse/HBASE-8483
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.94.4
>            Reporter: Eric Yu
>            Priority: Critical
>             Fix For: 0.95.1
>
>         Attachments: HBASE-8483-0.94.patch, HBASE-8483.patch, LeakZKConnections.java
>
>
> If one thread calls deleteStaleConnection while other threads are using connection, can
leak ZK connections.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message