hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8462) Custom timestamps should not be allowed to be negative
Date Wed, 15 May 2013 07:43:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658148#comment-13658148
] 

Enis Soztutar commented on HBASE-8462:
--------------------------------------

bq. Do we need the changes to TimeRange.java?
I've added those changes to make Scan not accept negative values as well. From ScanQueryMatcher
it seems that we do not need this change, depending on whether we want to allow negative ts
on scan limits or not. There is no harm in setting negative ts's on scans as long as you cannot
have negative ts in cells. 

Will update the patch with Ted's comments. 
                
> Custom timestamps should not be allowed to be negative
> ------------------------------------------------------
>
>                 Key: HBASE-8462
>                 URL: https://issues.apache.org/jira/browse/HBASE-8462
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.98.0, 0.94.8, 0.95.1
>
>         Attachments: hbase-8462_v1.patch, hbase-8462_v2.patch
>
>
> Client supplied timestamps should not be allowed to be negative, otherwise unpredictable
results will follow. Especially, since we are encoding the ts using Bytes.Bytes(long), negative
timestamps are sorted after positive ones. Plus, the new PB messages define ts' as uint64.

> Credit goes to Huned Lokhandwala for reporting this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message