hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8462) Custom timestamps should not be allowed to be negative
Date Sat, 11 May 2013 03:23:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655130#comment-13655130
] 

Ted Yu commented on HBASE-8462:
-------------------------------

{code}
+    if (timestamp < 0) {
+      throw new IllegalArgumentException("Timestamp cannot be negative");
{code}
Giving users more clue would help them pinpoint the problem. Please include timestamp in the
message.
{code}
+    if (minStamp < 0 || maxStamp < 0) {
+      throw new IllegalArgumentException("Timestamp cannot be negative");
+    }
{code}
Please be specific which timestamp is negative.

Please fill out Release Notes for this change.

Good job.
                
> Custom timestamps should not be allowed to be negative
> ------------------------------------------------------
>
>                 Key: HBASE-8462
>                 URL: https://issues.apache.org/jira/browse/HBASE-8462
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.98.0, 0.94.8, 0.95.1
>
>         Attachments: hbase-8462_v1.patch, hbase-8462_v2.patch
>
>
> Client supplied timestamps should not be allowed to be negative, otherwise unpredictable
results will follow. Especially, since we are encoding the ts using Bytes.Bytes(long), negative
timestamps are sorted after positive ones. Plus, the new PB messages define ts' as uint64.

> Credit goes to Huned Lokhandwala for reporting this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message