hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8218) Pass HConnection and ExecutorService as parameters to methods of AggregationClient
Date Sat, 11 May 2013 08:57:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655201#comment-13655201
] 

Hadoop QA commented on HBASE-8218:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12582774/HBase-8218_Trunk_V4.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5640//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5640//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5640//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5640//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5640//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5640//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5640//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5640//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5640//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5640//console

This message is automatically generated.
                
> Pass HConnection and ExecutorService as parameters to methods of AggregationClient
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-8218
>                 URL: https://issues.apache.org/jira/browse/HBASE-8218
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, Coprocessors
>    Affects Versions: 0.94.3
>            Reporter: cuijianwei
>            Assignee: cuijianwei
>             Fix For: 0.98.0
>
>         Attachments: 8218-trunk-v2-rerun.txt, 8218-trunk-v2.txt, 8218-trunk-v3-rerun.txt,
8218-trunk-v3.txt, HBASE-8218-0.94.3-v1.txt, HBASE-8218-0.94.3-v2.txt, HBASE-8218-0.94.3-v3.txt,
HBASE-8218-trunk-v1.txt, HBase-8218_Trunk_V4.patch
>
>
> In AggregationClient, methods such as max(...), min(...) pass 'tableName' as a parameter,
then a HTable will be created in the method, before the method return, the created HTable
will be closed.
> The process above may be heavy because each call must create and close a HTable. The
situation becomes worse when there is only one thread access HBase using AggregationClient.
The underly HConnection of created HTable will also be created and then closed each time when
we invoke these method because no other HTables using the HConnection. This operation is heavy.
Therefore, can we add another group of methods which pass HTable or HTablePool as a parameter
to methods defined in AggregationClient? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message