hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7897) Add support for tags to Cell Interface
Date Mon, 06 May 2013 16:36:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649845#comment-13649845
] 

stack commented on HBASE-7897:
------------------------------

Patch looks good except for this addition:

+  /**
+   * @return the total number of tags in the cell
+   */
+  int getNumTags();


Also, this may seem like a super nit but I think you should change the order in which the
methods show in the Interface to match the order done for the other elements of Cell so that
when someone is reading the Interface, it will be plain that tag-handling is just like row
or column or qualifier handling.

Good on you Ram.
                
> Add support for tags to Cell Interface
> --------------------------------------
>
>                 Key: HBASE-7897
>                 URL: https://issues.apache.org/jira/browse/HBASE-7897
>             Project: HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 0.95.1
>
>         Attachments: HBASE-7897_1.patch, HBASE-7897.patch
>
>
> Cell Interface has suppport for mvcc.   The only thing we'd add to Cell in the near future
is support for tags it would seem.  Should be easy to add.  Should add it now.  See backing
discussion here: https://issues.apache.org/jira/browse/HBASE-7233?focusedCommentId=13573784&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13573784
> Matt outlines what the additions to Cell might look like here:
> https://issues.apache.org/jira/browse/HBASE-7233?focusedCommentId=13531619&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13531619
> Would be good to get these in now.
> Marking as 0.96.  Can more later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message