hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7055) port HBASE-6371 tier-based compaction from 0.89-fb to trunk (with changes)
Date Wed, 15 May 2013 21:53:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658869#comment-13658869

Sergey Shelukhin commented on HBASE-7055:

bq. Isn't all data in a storefile flushed at the same time? Or is this something else? And
what is the subset we are referring to here? Is this flush time the earliest flush time of
a group of compacted filess?
Subset of data is a subset of data :) What it means is the minimum flush time of some data
in the file. When files are flushed, this value is set; when files are compacted, it preserves
the minimum of the values of the input files. So yeah...

Previous -1 was special flush time but now MAX_VALUE is special initializer:
+    long minFlushTime = Long.MAX_VALUE;
Is there going to be conflict? Should it be NO_MIN_FLUSH_TIME here instead of MAX_VALUE?
This is actually the initialized for determining the minimum. If it's still MAX_VALUE at the
end it will be reset to constant.

bq. I got about 1/3rd through and then my eyes started to glaze over. Will come back for a
better review. Patch is looking good.
Thanks! Although stripe compactions might be better review candidate of the two as far as
I am concerned ;)

> port HBASE-6371 tier-based compaction from 0.89-fb to trunk (with changes)
> --------------------------------------------------------------------------
>                 Key: HBASE-7055
>                 URL: https://issues.apache.org/jira/browse/HBASE-7055
>             Project: HBase
>          Issue Type: Task
>          Components: Compaction
>    Affects Versions: 0.95.2
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 0.95.1
>         Attachments: HBASE-6371-squashed.patch, HBASE-6371-v2-squashed.patch, HBASE-6371-v3-refactor-only-squashed.patch,
HBASE-6371-v4-refactor-only-squashed.patch, HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7055-v0.patch,
HBASE-7055-v1.patch, HBASE-7055-v2.patch, HBASE-7055-v3.patch, HBASE-7055-v4.patch, HBASE-7055-v5.patch,
HBASE-7055-v6.patch, HBASE-7055-v7.patch, HBASE-7055-v7.patch
> See HBASE-6371 for details.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message