hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5995) Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
Date Tue, 14 May 2013 00:21:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656575#comment-13656575
] 

Sergey Shelukhin commented on HBASE-5995:
-----------------------------------------

{code}
-        closeBarrier.endOp();
+        if (!closed) {
+          closeBarrier.endOp();
+        }
{code}
The start code is:
{code}
        boolean isClosed = closed;
        if (isClosed || !closeBarrier.beginOp()) {
          LOG.debug("HLog " + (isClosed ? "closed" : "closing") + ". Skipping rolling of writer");
          return regionsToFlush;
        }
{code}
End should not be called only if "isClosed || !closeBarrier.beginOp()" is false. isClosed
needs to be checked lest "closed" changed, and whether we could start the op.
In fact maybe it's better to move that if before "try"? (and keep logRollRunning in)
{code}
+          try {
+            sync();
+          } catch (IOException ioe) {
+            if (ioe.getMessage().contains("DFSOutputStream is closed")) {
+              //do not throw this here, sync() failed we will just close the writer
+            }
+          }
{code}
This "if" is pointless... should it throw in other cases? Also comment could be made more
descriptive :)

                
> Fix and reenable TestLogRolling.testLogRollOnPipelineRestart
> ------------------------------------------------------------
>
>                 Key: HBASE-5995
>                 URL: https://issues.apache.org/jira/browse/HBASE-5995
>             Project: HBase
>          Issue Type: Sub-task
>          Components: test
>            Reporter: stack
>            Assignee: Enis Soztutar
>            Priority: Blocker
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: hbase-5995_v1.patch, hbase-5995_v2.patch
>
>
> HBASE-5984 disabled this flakey test (See the issue for more).  This issue is about getting
it enabled again.  Made a blocker on 0.96.0 so it gets attention.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message