hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-1762) Remove concept of ZooKeeper from HConnection interface
Date Thu, 09 May 2013 02:43:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652688#comment-13652688
] 

Hudson commented on HBASE-1762:
-------------------------------

Integrated in hbase-0.95 #181 (See [https://builds.apache.org/job/hbase-0.95/181/])
    HBASE-1762 Remove concept of ZooKeeper from HConnection interface (Revision 1480502)
HBASE-1762 Remove concept of ZooKeeper from HConnection interface (Revision 1480455)

     Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.95/hbase-examples/src/test/java/org/apache/hadoop/hbase/coprocessor/example/TestZooKeeperScanPolicyObserver.java

stack : 
Files : 
* /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
* /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZooKeeperKeepAliveConnection.java
* /hbase/branches/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
* /hbase/branches/0.95/hbase-server/src/main/ruby/hbase/admin.rb
* /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java

                
> Remove concept of ZooKeeper from HConnection interface
> ------------------------------------------------------
>
>                 Key: HBASE-1762
>                 URL: https://issues.apache.org/jira/browse/HBASE-1762
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 0.20.0
>            Reporter: Ken Weiner
>            Assignee: stack
>             Fix For: 0.95.1
>
>         Attachments: 1762.addendum.txt, 1762v2.txt, 1762v3.txt, 1762v3.txt, 1762v3.txt,
1762v4.txt, 1762v5.txt, HBASE-1762.patch
>
>
> The concept of ZooKeeper is really an implementation detail and should not be exposed
in the {{HConnection}} interface.   Therefore, I suggest removing the {{HConnection.getZooKeeperWrapper()}}
method from the interface. 
> I couldn't find any uses of this method within the HBase code base except for in one
of the unit tests: {{org.apache.hadoop.hbase.TestZooKeeper}}.  This unit test should be changed
to instantiate the implementation of {{HConnection}} directly, allowing it to use the {{getZooKeeperWrapper()}}
method.  This requires making {{org.apache.hadoop.hbase.client.HConnectionManager.TableServers}}
public.  (I actually think TableServers should be moved out into an outer class, but in the
spirit of small patches, I'll refrain from suggesting that in this issue).
> I'll attach a patch for:
> # The removal of {{HConnection.getZooKeeperWrapper()}}
> # Change of {{TableServers}} class from private to public
> # Direct instantiation of {{TableServers}} within {{TestZooKeeper}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message