Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A925DFA5D for ; Wed, 17 Apr 2013 17:59:16 +0000 (UTC) Received: (qmail 13125 invoked by uid 500); 17 Apr 2013 17:59:16 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 13081 invoked by uid 500); 17 Apr 2013 17:59:16 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 13070 invoked by uid 99); 17 Apr 2013 17:59:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Apr 2013 17:59:16 +0000 Date: Wed, 17 Apr 2013 17:59:16 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8355) BaseRegionObserver#preCompactScannerOpen returns null MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634253#comment-13634253 ] Lars Hofhansl commented on HBASE-8355: -------------------------------------- I don't think this is right. The internal scanner passed is not the right scanner to use. I am surprised that this does not break many more tests. In Compactor.compact the result of preCompactScannerOpen need to be null in order to have the default action happening. > BaseRegionObserver#preCompactScannerOpen returns null > ----------------------------------------------------- > > Key: HBASE-8355 > URL: https://issues.apache.org/jira/browse/HBASE-8355 > Project: HBase > Issue Type: Bug > Components: Coprocessors > Affects Versions: 0.98.0, 0.94.8, 0.95.1 > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Attachments: 8355-0.94.patch, 8355.patch > > > As pointed out in https://github.com/forcedotcom/phoenix/pull/131, BaseRegionObserver#preCompactScannerOpen returns null by default, which hoses any coprocessors down the line, making override of this method mandatory. The fix is trivial, patch coming momentarily. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira