Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DAAB510AAC for ; Tue, 16 Apr 2013 04:53:24 +0000 (UTC) Received: (qmail 51988 invoked by uid 500); 16 Apr 2013 04:53:23 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 51456 invoked by uid 500); 16 Apr 2013 04:53:18 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 51382 invoked by uid 99); 16 Apr 2013 04:53:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Apr 2013 04:53:17 +0000 Date: Tue, 16 Apr 2013 04:53:16 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8341) RestoreSnapshotHandler.prepare() is not called by SnapshotManager and TakeSnapshotHandler should first acquire the table lock MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632556#comment-13632556 ] Hudson commented on HBASE-8341: ------------------------------- Integrated in HBase-TRUNK #4066 (See [https://builds.apache.org/job/HBase-TRUNK/4066/]) HBASE-8341 RestoreSnapshotHandler.prepare() is not called by SnapshotManager and TakeSnapshotHandler should first acquire the table lock (Revision 1468262) Result = FAILURE enis : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java > RestoreSnapshotHandler.prepare() is not called by SnapshotManager and TakeSnapshotHandler should first acquire the table lock > ------------------------------------------------------------------------------------------------------------------------------ > > Key: HBASE-8341 > URL: https://issues.apache.org/jira/browse/HBASE-8341 > Project: HBase > Issue Type: Bug > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Fix For: 0.98.0, 0.95.1 > > Attachments: hbase-8341_v1.patch > > > In HBASE-7848, we added table lock to enabled/disabled snapshot handlers, and fixed SnapshotManager to call CloneSnapshotHandler.prepare() in HBASE-7957. It seems that we overlooked the RestoreSnapshotHandler.prepare(). In this issue we should fix that so that we acquire the table lock in restore snapshot. > There is also a slightly related issue where TakeSnapshotHandler first loads the HTD, then acquires the table lock. The order should be swapped to guard against concurrent alter table statements. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira