Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4FFCEF863 for ; Fri, 12 Apr 2013 23:00:16 +0000 (UTC) Received: (qmail 10977 invoked by uid 500); 12 Apr 2013 23:00:16 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 10859 invoked by uid 500); 12 Apr 2013 23:00:16 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 10849 invoked by uid 99); 12 Apr 2013 23:00:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Apr 2013 23:00:16 +0000 Date: Fri, 12 Apr 2013 23:00:16 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8322) Re-enable hbase checksums by default MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630722#comment-13630722 ] Lars Hofhansl commented on HBASE-8322: -------------------------------------- I am somewhat neutral about this. We disabled it, because unless short circuit reading is enabled (or if the data is read by the region server is not local) we'd actually calculate the checksum twice. What if folks have a separate HDFS and HBase clusters (not that that would make sense, but I think some folks have this)? In that case, would we always calculate the checksum twice? > Re-enable hbase checksums by default > ------------------------------------ > > Key: HBASE-8322 > URL: https://issues.apache.org/jira/browse/HBASE-8322 > Project: HBase > Issue Type: Improvement > Components: Filesystem Integration > Reporter: Enis Soztutar > Assignee: Enis Soztutar > Fix For: 0.98.0, 0.95.1 > > Attachments: hbase-8322_v1.patch > > > Double checksumming issues in HBase level checksums(HBASE-5074) has been fixed in HBASE-6868. However, that patch also disables hbase checksums by default. I think we should re-enable it by default, and document the interaction with shortcircuit reads. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira