Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 8 Apr 2013 18:17:19 +0000 (UTC)
From: "Nick Dimiduk (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12641317.1365399416548.128863.1365445039270@arcas>
In-Reply-To: <JIRA.12641317.1365399416548@arcas>
References: <JIRA.12641317.1365399416548@arcas>
Subject: [jira] [Commented] (HBASE-8288) HBaseFileSystem: Refactoring and
 correct semantics for createPath methods
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-8288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625626#comment-13625626 ] 

Nick Dimiduk commented on HBASE-8288:
-------------------------------------

Since use of the static block is purely performance, please add a comment saying as much. Otherwise, v2 looks good to me as well.
                
> HBaseFileSystem: Refactoring and correct semantics for createPath methods
> -------------------------------------------------------------------------
>
>                 Key: HBASE-8288
>                 URL: https://issues.apache.org/jira/browse/HBASE-8288
>             Project: HBase
>          Issue Type: Bug
>          Components: Filesystem Integration
>    Affects Versions: 0.94.6
>            Reporter: Himanshu Vashishtha
>            Assignee: Himanshu Vashishtha
>             Fix For: 0.94.7
>
>         Attachments: HBase-8288-v1.patch, HBase-8288-v2.patch
>
>
> This jira is for two issues I see in the HBaseFileSystem class:
> 1) Load testing on a 7 node cluster using ycsb insert workload shows that static initialization of conf properties results in a slightly better throughput. Though the initialization uses HBaseConfiguration.create() call which is expensive (and I tried to avoid that in its first version), this class is used for most of the filesystem class, and had to invoke an additional checkAndSetXX call before making the fs call because it is not certain whether the retry properties are set or not. Having initialize them in static block removes that limitation.
> 2) Correct semantics for CreatePathXXX method. In case the overwrite flag is false and file already exists, underlying fs throws an exception. It should be re-thrown to the caller.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira