Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 416ECFC4C for ; Sat, 6 Apr 2013 23:03:16 +0000 (UTC) Received: (qmail 11690 invoked by uid 500); 6 Apr 2013 23:03:16 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 11662 invoked by uid 500); 6 Apr 2013 23:03:16 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 11651 invoked by uid 99); 6 Apr 2013 23:03:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Apr 2013 23:03:16 +0000 Date: Sat, 6 Apr 2013 23:03:15 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8240) CompoundConfiguration should implement Iterable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624528#comment-13624528 ] stack commented on HBASE-8240: ------------------------------ -1 for 0.94. It is not even needed in 0.95 it seems. > CompoundConfiguration should implement Iterable > ----------------------------------------------- > > Key: HBASE-8240 > URL: https://issues.apache.org/jira/browse/HBASE-8240 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Ted Yu > Fix For: 0.95.1, 0.98.0 > > Attachments: 8240-v1.txt, 8240-v2.txt, 8240-v3.txt, 8240-v4.txt, 8240-v6.txt, 8240-v7.txt > > > Here is from hadoop Configuration class: > {code} > public class Configuration implements Iterable>, > {code} > There're 3 addXX() methods for CompoundConfiguration: > {code} > public CompoundConfiguration add(final Configuration conf) { > public CompoundConfiguration addWritableMap( > final Map map) { > public CompoundConfiguration addStringMap(final Map map) { > {code} > Parameters to these methods all support iteration. > We can enhance ImmutableConfigMap with the following new method: > {code} > public abstract java.util.Iterator iterator(); > {code} > Then the following method of CompoundConfiguration can be implemented: > {code} > public Iterator> iterator() { > {code} > This enhancement would be useful in scenario where a mutable Configuration is required. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira