Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C4B12F03A for ; Tue, 2 Apr 2013 02:07:16 +0000 (UTC) Received: (qmail 13451 invoked by uid 500); 2 Apr 2013 02:07:15 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 13396 invoked by uid 500); 2 Apr 2013 02:07:15 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 13247 invoked by uid 99); 2 Apr 2013 02:07:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Apr 2013 02:07:15 +0000 Date: Tue, 2 Apr 2013 02:07:15 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8225) [replication] minor code bug when registering ReplicationLogCleaner MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619437#comment-13619437 ] Hudson commented on HBASE-8225: ------------------------------- Integrated in HBase-TRUNK #4005 (See [https://builds.apache.org/job/HBase-TRUNK/4005/]) HBASE-8225 [replication] minor code bug when registering ReplicationLogCleaner (Jerry He) (Revision 1463283) Result = FAILURE sershe : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java > [replication] minor code bug when registering ReplicationLogCleaner > ------------------------------------------------------------------- > > Key: HBASE-8225 > URL: https://issues.apache.org/jira/browse/HBASE-8225 > Project: HBase > Issue Type: Bug > Components: Replication > Affects Versions: 0.94.6 > Reporter: Jerry He > Assignee: Jerry He > Priority: Minor > Fix For: 0.95.0, 0.96.0, 0.94.7 > > Attachments: HBASE-8255-0.94.patch, HBASE-8255-trunk.patch > > > We try to register ReplicationLogCleaner by default. This is done by calling Replication.decorateMasterConfiguration()in the master. > In the current Replication.decorateMasterConfiguration(): > ... > String plugins = conf.get(HBASE_MASTER_LOGCLEANER_PLUGINS); > if (!plugins.contains(ReplicationLogCleaner.class.toString())) { > conf.set(HBASE_MASTER_LOGCLEANER_PLUGINS, > plugins + "," + ReplicationLogCleaner.class.getCanonicalName()); > } > ... > ReplicationLogCleaner.class.toString() will return prefix 'class' to the full class name, which will make the if checking mostly useless. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira