Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 1 Apr 2013 20:49:17 +0000 (UTC)
From: "Sergey Shelukhin (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12639873.1364587439754.87215.1364849357242@arcas>
In-Reply-To: <JIRA.12639873.1364587439754@arcas>
References: <JIRA.12639873.1364587439754@arcas>
Subject: [jira] [Commented] (HBASE-8225) [replication] minor code bug when
 registering ReplicationLogCleaner
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-8225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619147#comment-13619147 ] 

Sergey Shelukhin commented on HBASE-8225:
-----------------------------------------

Committed to 95 and trunk. [~lhofhansl] any objections to 94?
                
> [replication] minor code bug when registering ReplicationLogCleaner
> -------------------------------------------------------------------
>
>                 Key: HBASE-8225
>                 URL: https://issues.apache.org/jira/browse/HBASE-8225
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 0.94.6
>            Reporter: Jerry He
>            Assignee: Jerry He
>            Priority: Minor
>             Fix For: 0.95.0, 0.96.0, 0.94.7
>
>         Attachments: HBASE-8255-0.94.patch, HBASE-8255-trunk.patch
>
>
> We try to register ReplicationLogCleaner by default. This is done by calling Replication.decorateMasterConfiguration()in the master. 
> In the current Replication.decorateMasterConfiguration(): 
> ...
>     String plugins = conf.get(HBASE_MASTER_LOGCLEANER_PLUGINS);
>     if (!plugins.contains(ReplicationLogCleaner.class.toString())) {
>       conf.set(HBASE_MASTER_LOGCLEANER_PLUGINS,
>           plugins + "," + ReplicationLogCleaner.class.getCanonicalName());
>     }
> ...
> ReplicationLogCleaner.class.toString() will return prefix 'class' to the full class name, which will make the if checking mostly useless.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira