Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2B9D4F69A for ; Mon, 1 Apr 2013 18:33:16 +0000 (UTC) Received: (qmail 12119 invoked by uid 500); 1 Apr 2013 18:33:16 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 12088 invoked by uid 500); 1 Apr 2013 18:33:15 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 12080 invoked by uid 99); 1 Apr 2013 18:33:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Apr 2013 18:33:15 +0000 Date: Mon, 1 Apr 2013 18:33:15 +0000 (UTC) From: "Sergey Shelukhin (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-7970) Improve file descriptor usage: currently, there are two file descriptors per storefile MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shelukhin updated HBASE-7970: ------------------------------------ Attachment: HBASE-7970-v1.patch r feedback, fix javadoc > Improve file descriptor usage: currently, there are two file descriptors per storefile > -------------------------------------------------------------------------------------- > > Key: HBASE-7970 > URL: https://issues.apache.org/jira/browse/HBASE-7970 > Project: HBase > Issue Type: Sub-task > Reporter: Himanshu Vashishtha > Assignee: Sergey Shelukhin > Attachments: HBASE-7970-v0.patch, HBASE-7970-v1.patch > > > This is because there are two open calls in the HFile: one with checksum and another for without checksum support in v2: > see the method in HFile:createReaderWithEncoding() > {code} > FSDataInputStream fsdis = fs.open(path); > FSDataInputStream fsdisNoFsChecksum = fsdis; > // If the fs is not an instance of HFileSystem, then create an > // instance of HFileSystem that wraps over the specified fs. > // In this case, we will not be able to avoid checksumming inside > // the filesystem. > if (!(fs instanceof HFileSystem)) { > hfs = new HFileSystem(fs); > } else { > hfs = (HFileSystem)fs; > // open a stream to read data without checksum verification in > // the filesystem > fsdisNoFsChecksum = hfs.getNoChecksumFs().open(path); > } > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira