Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 87F44FB01 for ; Tue, 23 Apr 2013 20:07:20 +0000 (UTC) Received: (qmail 25483 invoked by uid 500); 23 Apr 2013 20:07:19 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 25438 invoked by uid 500); 23 Apr 2013 20:07:19 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 25401 invoked by uid 99); 23 Apr 2013 20:07:19 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Apr 2013 20:07:19 +0000 Date: Tue, 23 Apr 2013 20:07:19 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-7437) Improve CompactSelection MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639538#comment-13639538 ] Hudson commented on HBASE-7437: ------------------------------- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #507 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/507/]) HBASE-7437 Improve CompactSelection (Hiroshi Ikeda) (Revision 1470754) Result = ABORTED sershe : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/OffPeakCompactions.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/OffPeakHours.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestOffPeakCompactions.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestOffPeakHours.java > Improve CompactSelection > ------------------------ > > Key: HBASE-7437 > URL: https://issues.apache.org/jira/browse/HBASE-7437 > Project: HBase > Issue Type: Improvement > Components: Compaction > Reporter: Hiroshi Ikeda > Assignee: Hiroshi Ikeda > Priority: Minor > Attachments: HBASE-7437.patch, HBASE-7437-V2.patch, HBASE-7437-V3.patch, HBASE-7437-V4.patch > > > 1. Using AtomicLong makes CompactSelection simple and improve its performance. > 2. There are unused fields and methods. > 3. The fields should be private. > 4. Assertion in the method finishRequest seems wrong: > {code} > public void finishRequest() { > if (isOffPeakCompaction) { > long newValueToLog = -1; > synchronized(compactionCountLock) { > assert !isOffPeakCompaction : "Double-counting off-peak count for compaction"; > {code} > The above assertion seems almost always false. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira