Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3FB45FD77 for ; Tue, 16 Apr 2013 08:15:19 +0000 (UTC) Received: (qmail 6811 invoked by uid 500); 16 Apr 2013 08:15:19 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 6696 invoked by uid 500); 16 Apr 2013 08:15:18 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 6662 invoked by uid 99); 16 Apr 2013 08:15:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Apr 2013 08:15:17 +0000 Date: Tue, 16 Apr 2013 08:15:17 +0000 (UTC) From: "Nicolas Liochon (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-6870) HTable#coprocessorExec always scan the whole table MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632652#comment-13632652 ] Nicolas Liochon commented on HBASE-6870: ---------------------------------------- Fascinating improvement I would say :-) Some comments: - You've reorganized the imports, that will create conflicts when people will merge their patches ;-] - There is a parameter, but it's never used useCache with a value set to false. Wouldn't be better to remove it? - Just a question: why a LinkedHashMap? - The method should return the interface (Map) but not the real type. - Using the Map with a byte[] is brittle imho. - Does getKeysToRegionsInRange needs to be public? > HTable#coprocessorExec always scan the whole table > --------------------------------------------------- > > Key: HBASE-6870 > URL: https://issues.apache.org/jira/browse/HBASE-6870 > Project: HBase > Issue Type: Improvement > Components: Coprocessors > Affects Versions: 0.94.1, 0.95.0, 0.95.2 > Reporter: chunhui shen > Assignee: chunhui shen > Priority: Critical > Fix For: 0.98.0, 0.95.1 > > Attachments: 6870-v4.txt, HBASE-6870.patch, HBASE-6870-testPerformance.patch, HBASE-6870v2.patch, HBASE-6870v3.patch, hbase-6870v5.patch > > > In current logic, HTable#coprocessorExec always scan the whole table, its efficiency is low and will affect the Regionserver carrying .META. under large coprocessorExec requests -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira