hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8418) Caching KeyValue.getRowLength() to improve scan performance
Date Wed, 24 Apr 2013 16:35:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640618#comment-13640618
] 

Matteo Bertozzi commented on HBASE-8418:
----------------------------------------

it looks reasonable, but I want to verify if the performance improvement is worth the 2 extra
bytes used.

my initial notes says, from:
* Bytes.toShort()
* StoreScanner.next()
* KeyValue.KeyComparator.compare()
* HFileReaderv2.ScannerV2.blockSeek()
* Bytes.LexicographicalCompareHolder.UnsafeComparer.compareTo()

to:
* StoreScanner.next()
* HFileReaderv2.ScannerV2.blockSeek()
* Bytes.LexicographicalCompareHolder.UnsafeComparer.compareTo()
* Bytes.toShort()
* KeyValue.KeyComparator.compare()

I'll take again the results with the number of calls and percentage to be more accurate
                
> Caching KeyValue.getRowLength() to improve scan performance
> -----------------------------------------------------------
>
>                 Key: HBASE-8418
>                 URL: https://issues.apache.org/jira/browse/HBASE-8418
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>         Attachments: HBASE-8418-0.94-v0.patch
>
>
> Looking at the profile seems that Bytes.toShort() is called a lot.
> the calls are in ScanQueryMatcher.match() and KeyValue.KeyComparator.compare()
> getKeyLength() is already cached, but getRowLength() is not.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message