hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8413) Snapshot verify region will always fail if the HFile has been archived
Date Wed, 24 Apr 2013 05:15:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640087#comment-13640087
] 

stack commented on HBASE-8413:
------------------------------

+1

You want to commit [~mbertozzi]?
                
> Snapshot verify region will always fail if the HFile has been archived
> ----------------------------------------------------------------------
>
>                 Key: HBASE-8413
>                 URL: https://issues.apache.org/jira/browse/HBASE-8413
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 0.94.6, 0.95.0
>            Reporter: Jerry He
>            Assignee: Jerry He
>             Fix For: 0.98.0, 0.94.7
>
>         Attachments: HBASE-8413-trunk.patch
>
>
> MasterSnapshotVerifier::verifyRegion():
> ...
> // check to see if hfile is present in the real table
>         String fileName = hfile.getPath().getName();
>         Path file = new Path(realCfDir, fileName);
>         Path archived = new Path(archivedCfDir, fileName);
>         if (!fs.exists(file) && !file.equals(archived)) {
>           throw new CorruptedSnapshotException("Can't find hfile: " + hfile.getPath()
>               + " in the real (" + realCfDir + ") or archive (" + archivedCfDir
>               + ") directory for the primary table.", snapshot);
>         }
> ....
> The second part of the if condition will always be true:
> !file.equals(archived)
> Corrected:
> if (!fs.exists(file) && !fs.exists(archived))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message