hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8378) add 'force' option for drop table
Date Wed, 24 Apr 2013 15:13:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640523#comment-13640523
] 

Nick Dimiduk commented on HBASE-8378:
-------------------------------------

Haha, yep. [{{tableExists}}|https://github.com/apache/hbase/blob/trunk/hbase-server/src/main/ruby/hbase/admin.rb#L159]
is more like an assert, throws an exception when the table doesn't exist. [{{exists?}}|https://github.com/apache/hbase/blob/trunk/hbase-server/src/main/ruby/hbase/admin.rb#L586]
is gentler, just communicates with the admin to check status. Technically this code is making
the call to {{admin.tableExists}} twice when {{force}} is enabled.
                
> add 'force' option for drop table
> ---------------------------------
>
>                 Key: HBASE-8378
>                 URL: https://issues.apache.org/jira/browse/HBASE-8378
>             Project: HBase
>          Issue Type: Improvement
>          Components: shell, Usability
>    Affects Versions: 0.94.6.1, 0.95.0
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 0001-HBASE-8378-shell-add-force-option-to-drop.patch
>
>
> Does this logic look familiar?
> {noformat}
> def drop_table(name):
>   if (!admin.table_exists?(name):
>     return
>   if (admin.enabled?(name)):
>     admin.disable_table(name)
>   admin.drop_table(name)
> {noformat}
> Let's add a force option to 'drop' that does exactly this. We'll save 6 lines of code
for thousands of developers in millions of scripts.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message