hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8372) Provide mutability to CompoundConfiguration
Date Tue, 23 Apr 2013 18:19:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639341#comment-13639341
] 

Ted Yu commented on HBASE-8372:
-------------------------------

Using example is always the best way to understand assumptions.
bq. hbase.set("hbasekey", "hbasevalue");
I am not sure the above usage is supported currently - namely, retrieval of new key/value
after the add() call.
Looking at current TestCompoundConfiguration:
{code}
    CompoundConfiguration compoundConf = new CompoundConfiguration()
        .add(baseConf)
        .add(conf);
{code}
There is no set() call after the add() calls.

In your example above, I think the correct way of overriding key with value after the add(hri)
call is made should be using another add() call. This is because the order of adding hbase,
htd and hri to the compound is significant. When htd and hri contain entries with same key
but different values, I do not expect htd.set(key, newValue) would be effective.
                
> Provide mutability to CompoundConfiguration
> -------------------------------------------
>
>                 Key: HBASE-8372
>                 URL: https://issues.apache.org/jira/browse/HBASE-8372
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Ted Yu
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-8372.patch, hbase-8372.v2.patch, hbase-8372.v3.patch, hbase-8372.v4.patch,
hbase-8372.v5.patch
>
>
> In discussion of HBASE-8347, it was proposed that CompoundConfiguration should support
mutability.
> This can be done by consolidating ImmutableConfigMap's on first modification to CompoundConfiguration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message