hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-8355) BaseRegionObserver#preCompactScannerOpen returns null
Date Wed, 17 Apr 2013 18:43:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634301#comment-13634301
] 

Jesse Yates edited comment on HBASE-8355 at 4/17/13 6:43 PM:
-------------------------------------------------------------

Either way is fine - I've just never like using Pair to hack multiple returns :) In keeping
with the style though, doing the Pair return seems more consistent.

Yeah, a new patch would be great Andy! I was just thinking about backwards compat - it would
be nice to not lose it and just add a new method with the new return that does the correct
delegate method calling in BaseRegionObserver.
                
      was (Author: jesse_yates):
    Either way is fine - I've just never like the Pair to hack multiple returns :) In keeping
with the style though, doing the Pair return seems more consistent.
                  
> BaseRegionObserver#preCompactScannerOpen returns null
> -----------------------------------------------------
>
>                 Key: HBASE-8355
>                 URL: https://issues.apache.org/jira/browse/HBASE-8355
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>    Affects Versions: 0.98.0, 0.94.8, 0.95.1
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>         Attachments: 8355-0.94.patch, 8355.patch
>
>
> As pointed out in https://github.com/forcedotcom/phoenix/pull/131, BaseRegionObserver#preCompactScannerOpen
returns null by default, which hoses any coprocessors down the line, making override of this
method mandatory. The fix is trivial, patch coming momentarily.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message