hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8355) BaseRegionObserver#preCompactScannerOpen returns null
Date Wed, 17 Apr 2013 18:29:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634286#comment-13634286
] 

Lars Hofhansl commented on HBASE-8355:
--------------------------------------

This is really my fault. I needed coprocessor hooks for compactions that could return a new
scanner, but also indicate when the default is used, returning null to indicate using the
default seemed the best approach then... I did not think about chaining. My bad.

Would need to think about a good API, that can:
# return a scanner when needed from the hook
# indicate that the default action should be used
# allow for chaining

                
> BaseRegionObserver#preCompactScannerOpen returns null
> -----------------------------------------------------
>
>                 Key: HBASE-8355
>                 URL: https://issues.apache.org/jira/browse/HBASE-8355
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>    Affects Versions: 0.98.0, 0.94.8, 0.95.1
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>         Attachments: 8355-0.94.patch, 8355.patch
>
>
> As pointed out in https://github.com/forcedotcom/phoenix/pull/131, BaseRegionObserver#preCompactScannerOpen
returns null by default, which hoses any coprocessors down the line, making override of this
method mandatory. The fix is trivial, patch coming momentarily.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message