hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8341) RestoreSnapshotHandler.prepare() is not called by SnapshotManager and TakeSnapshotHandler should first acquire the table lock
Date Tue, 16 Apr 2013 04:53:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632556#comment-13632556
] 

Hudson commented on HBASE-8341:
-------------------------------

Integrated in HBase-TRUNK #4066 (See [https://builds.apache.org/job/HBase-TRUNK/4066/])
    HBASE-8341 RestoreSnapshotHandler.prepare() is not called by SnapshotManager and TakeSnapshotHandler
should first acquire the table lock (Revision 1468262)

     Result = FAILURE
enis : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/RestoreSnapshotHandler.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java

                
> RestoreSnapshotHandler.prepare() is not called by SnapshotManager  and TakeSnapshotHandler
should first acquire the table lock
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-8341
>                 URL: https://issues.apache.org/jira/browse/HBASE-8341
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: hbase-8341_v1.patch
>
>
> In HBASE-7848, we added table lock to enabled/disabled snapshot handlers, and fixed SnapshotManager
to call CloneSnapshotHandler.prepare() in HBASE-7957. It seems that we overlooked the RestoreSnapshotHandler.prepare().
In this issue we should fix that so that we acquire the table lock in restore snapshot. 
> There is also a slightly related issue where TakeSnapshotHandler first loads the HTD,
then acquires the table lock. The order should be swapped to guard against concurrent alter
table statements. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message