hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Corgan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8317) Seek returns wrong result with PREFIX_TREE Encoding
Date Fri, 12 Apr 2013 06:05:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629833#comment-13629833
] 

Matt Corgan commented on HBASE-8317:
------------------------------------

Should be ok to commit both tests.  I think it's important to have the fine-grained tests
in the prefix-tree module to prove its correctness with the simplest test possible, but those
tests only verify the prefix-tree code.  Tests in hbase-server can cover all encoding types.

The downside to building up redundant tests in hbase-server is that we will always be afraid
to remove them or modify them, creating a maintenance struggle.  We should keep it I think,
but be conscious of the fact that too course-grained of a test suite may slow us down later.
                
> Seek returns wrong result with PREFIX_TREE Encoding
> ---------------------------------------------------
>
>                 Key: HBASE-8317
>                 URL: https://issues.apache.org/jira/browse/HBASE-8317
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.95.0
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>         Attachments: HBASE-8317-v1.patch, hbase-trunk-8317.patch, hbase-trunk-8317v3.patch
>
>
> TestPrefixTreeEncoding#testSeekWithFixedData from the patch could reproduce the bug.
> An example of the bug case:
> Suppose the following rows:
> 1.row3/c1:q1/
> 2.row3/c1:q2/
> 3.row3/c1:q3/
> 4.row4/c1:q1/
> 5.row4/c1:q2/
> After seeking the row 'row30', the expected peek KV is row4/c1:q1/, but actual is row3/c1:q1/.
> I just fix this bug case in the patch, 
> Maybe we can do more for other potential problems if anyone is familiar with the code
of PREFIX_TREE

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message