hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8258) Make mapreduce tests pass on hadoop2
Date Fri, 05 Apr 2013 00:24:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623114#comment-13623114

Jonathan Hsieh commented on HBASE-8258:

bq. Did you mean that we should wait for 2.0.4-alpha to come out ? I think for 0.95, we should
use 2.0.4-alpha which is to be released soon.

I don't want to build off of things that aren't released yet, especially a SNAPSHOT jar --
it will change underneath us and cause us pain by introducing another variable that culd introduces
problems under us.

bq. That was how the HBaseConfiguration.merge() call in HBaseTestingUtility.java came about

It says what we did but I'm not able to get a simple explanation of why from it.  

At least for the limited test cases, the copyConfigurationValues changes seem to fix the problem
(without the merge call).  Extraneous calls mean we didn't understand how or why it fixed
the problem.  The comment on copyConfigurationValues() is a little more helpful (it gives
me a clue why, but doesn't get down to which particular variables are important.  

Without understanding this we don't know if and why all the other mr tests on need these tweaks.
 Should it get folded in to all them?  Why or why not?  How can we make it so that future
tests don't run into these problems?

bq. Such comments have been in TestImportExport.

It is more important to convey why things are they way they are in the comments or summarize
blocks of code do a single idea that we can verify in review or in code reading.  We shouldn't
propagate vague comments from the past -- we should make them clearer for the next person.

bq. For SecureBulkLoadEndpoint.java, here is the background:

>From my testing at the moment (on hadoop 2.0.2-alpha) this is out of scope.  If and when
it becomes an issue with hadoop 2.0.4-beta, we'll address it then.

> Make mapreduce tests pass on hadoop2
> ------------------------------------
>                 Key: HBASE-8258
>                 URL: https://issues.apache.org/jira/browse/HBASE-8258
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>            Reporter: stack
>            Priority: Blocker
>             Fix For: 0.95.1
>         Attachments: 8258-plain.txt, 8258-v1-hadoop-2.0.txt
> HBASE-7904 was a first attempt at making this work but it got lost in the weeds.
> This is a new attempt at making hbase mapreduce jobs run on hadoop2 (w/o breaking mapreduce
on hadoop1)

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message