hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8240) CompoundConfiguration should implement Iterable
Date Thu, 04 Apr 2013 06:01:28 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621840#comment-13621840
] 

stack commented on HBASE-8240:
------------------------------

Suggest removing "... which should only be conducted when absolutely necessary." on commit.

Iterable<Map.Entry<String,String>>

Is all config. in this CompoundConfiguration a String key and a String value?  No ints, longs,
etc.?

I suppose it is ok because base Configuration does this.

Do we have to save up all of the Configuation into a HashMap to decorate it with an unmodifiable?

Where do we need this functionatlity?


                
> CompoundConfiguration should implement Iterable
> -----------------------------------------------
>
>                 Key: HBASE-8240
>                 URL: https://issues.apache.org/jira/browse/HBASE-8240
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.95.1, 0.98.0
>
>         Attachments: 8240-v1.txt, 8240-v2.txt, 8240-v3.txt, 8240-v4.txt, 8240-v6.txt
>
>
> Here is from hadoop Configuration class:
> {code}
> public class Configuration implements Iterable<Map.Entry<String,String>>,
> {code}
> There're 3 addXX() methods for CompoundConfiguration:
> {code}
>   public CompoundConfiguration add(final Configuration conf) {
>   public CompoundConfiguration addWritableMap(
>       final Map<ImmutableBytesWritable, ImmutableBytesWritable> map) {
>   public CompoundConfiguration addStringMap(final Map<String, String> map) {
> {code}
> Parameters to these methods all support iteration.
> We can enhance ImmutableConfigMap with the following new method:
> {code}
>   public abstract java.util.Iterator iterator();
> {code}
> Then the following method of CompoundConfiguration can be implemented:
> {code}
>   public Iterator<Map.Entry<String, String>> iterator() {
> {code}
> This enhancement would be useful in scenario where a mutable Configuration is required.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message