hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8225) [replication] minor code bug when registering ReplicationLogCleaner
Date Tue, 02 Apr 2013 10:41:19 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619685#comment-13619685
] 

Hudson commented on HBASE-8225:
-------------------------------

Integrated in HBase-0.94 #935 (See [https://builds.apache.org/job/HBase-0.94/935/])
    HBASE-8225 [replication] minor code bug when registering ReplicationLogCleaner (Jerry
He) (Revision 1463344)

     Result = SUCCESS
sershe : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java

                
> [replication] minor code bug when registering ReplicationLogCleaner
> -------------------------------------------------------------------
>
>                 Key: HBASE-8225
>                 URL: https://issues.apache.org/jira/browse/HBASE-8225
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 0.94.6
>            Reporter: Jerry He
>            Assignee: Jerry He
>            Priority: Minor
>             Fix For: 0.95.0, 0.96.0, 0.94.7
>
>         Attachments: HBASE-8255-0.94.patch, HBASE-8255-trunk.patch
>
>
> We try to register ReplicationLogCleaner by default. This is done by calling Replication.decorateMasterConfiguration()in
the master. 
> In the current Replication.decorateMasterConfiguration(): 
> ...
>     String plugins = conf.get(HBASE_MASTER_LOGCLEANER_PLUGINS);
>     if (!plugins.contains(ReplicationLogCleaner.class.toString())) {
>       conf.set(HBASE_MASTER_LOGCLEANER_PLUGINS,
>           plugins + "," + ReplicationLogCleaner.class.getCanonicalName());
>     }
> ...
> ReplicationLogCleaner.class.toString() will return prefix 'class' to the full class name,
which will make the if checking mostly useless.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message