hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Marc Spaggiari (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8220) can we record the count opened HTable for HTablePool
Date Fri, 12 Apr 2013 12:52:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630024#comment-13630024
] 

Jean-Marc Spaggiari commented on HBASE-8220:
--------------------------------------------

Passed locally for me too:
{code}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.816 sec
Running org.apache.hadoop.hbase.client.TestHTablePool$TestHTableThreadLocalPool
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 108.551 sec

Results :

Tests run: 18, Failures: 0, Errors: 0, Skipped: 0
{code}

+1

Don't forget that HTablePool is gone for 0.95 and above. So this patch will be for temporary
use only. Now you will need a commiter to take a look at it and apply it in 0.94.x.
                
> can we record the count opened HTable for HTablePool
> ----------------------------------------------------
>
>                 Key: HBASE-8220
>                 URL: https://issues.apache.org/jira/browse/HBASE-8220
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 0.94.3
>            Reporter: cuijianwei
>         Attachments: HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt, HBASE-8220-0.94.3.txt-v2,
HBASE-8220-0.94.3-v2.txt, HBASE-8220-0.94.3-v3.txt, HBASE-8220-0.94.3-v4.txt, HBASE-8220-0.94.3-v5.txt
>
>
> In HTablePool, we have a method getCurrentPoolSize(...) to get how many opened HTable
has been pooled. However, we don't know ConcurrentOpenedHTable which means the count of HTable
get from HTablePool.getTable(...) and don't return to HTablePool by PooledTable.close(). The
ConcurrentOpenedHTable may be meaningful because it indicates how many HTables should be opened
for the application which may help us set the appropriate MaxSize of HTablePool. Therefore,
we can and a ConcurrentOpenedHTable as a counter in HTablePool.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message