hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chunhui shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8219) Align Offline Merge with Online Merge
Date Mon, 01 Apr 2013 04:09:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618597#comment-13618597
] 

chunhui shen commented on HBASE-8219:
-------------------------------------

bq.The second and third calls wouldn't have effect because server is null.So if we expose
createMergedRegion() as public method, we can call it directly.
merged.openHRegion(reporter) is also called in RegionMergeTransaction#openMergedRegion.

bq.Maybe we can also implement hbase shell bindings for online one. 
Shell command of online region is already done(HBASE-8189)

IMHO, 
1.We should fix the snapshot break caused by offline merge now
2.Do some easy alignment about the code of online merge and offline merge, since we plan to
remove offline merge in a futuer moment
                
> Align Offline Merge with Online Merge
> -------------------------------------
>
>                 Key: HBASE-8219
>                 URL: https://issues.apache.org/jira/browse/HBASE-8219
>             Project: HBase
>          Issue Type: Task
>          Components: regionserver
>    Affects Versions: 0.95.0
>            Reporter: Matteo Bertozzi
>            Assignee: chunhui shen
>         Attachments: hbase-8219v1.patch, hbase-8219v2.patch
>
>
> After HBASE-7403 we now have two different tools for online and offline merge, and the
result produced by the two are different. (the online one works with snapshots, the offline
not)
> We should remove the offline one, or align it to the online code.
> Most of the offline code in HRegion.merge() can be replaced with the one in RegionMergeTransaction,
used by the online version.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message