hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-8218) pass HTable as a parameter to method of AggregationClient
Date Fri, 12 Apr 2013 03:55:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629754#comment-13629754
] 

Ted Yu commented on HBASE-8218:
-------------------------------

{code}
+  public void close() throws IOException {
+    this.threadPool.shutdown();
{code}
Can you introduce a flag so that we know whether AggregationClient has been closed ?
Do we need to wait for the shutdown to finish before returning from close() ?
                
> pass HTable as a parameter to method of AggregationClient
> ---------------------------------------------------------
>
>                 Key: HBASE-8218
>                 URL: https://issues.apache.org/jira/browse/HBASE-8218
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, Coprocessors
>    Affects Versions: 0.94.3
>            Reporter: cuijianwei
>         Attachments: HBASE-8218-0.94.3-v1.txt
>
>
> In AggregationClient, methods such as max(...), min(...) pass 'tableName' as a parameter,
then a HTable will be created in the method, before the method return, the created HTable
will be closed.
> The process above may be heavy because each call must create and close a HTable. The
situation becomes worse when there is only one thread access HBase using AggregationClient.
The underly HConnection of created HTable will also be created and then closed each time when
we invoke these method because no other HTables using the HConnection. This operation is heavy.
Therefore, can we add another group of methods which pass HTable or HTablePool as a parameter
to methods defined in AggregationClient? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message