hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7970) Improve file descriptor usage: currently, there are two file descriptors per storefile
Date Wed, 24 Apr 2013 21:57:16 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641015#comment-13641015
] 

Enis Soztutar commented on HBASE-7970:
--------------------------------------

bq. Javadoc warning seems to be from other build.
This should have generated a warning, no? The parameter name is empty after @ param. 
{code}
   * @param For how many checksumOk calls to turn off the HBase checksum.
   */
  public FSDataInputStream fallbackToFsChecksum(int offCount) throws IOException {
{code}
                
> Improve file descriptor usage: currently, there are two file descriptors per storefile
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-7970
>                 URL: https://issues.apache.org/jira/browse/HBASE-7970
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Himanshu Vashishtha
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7970-v0.patch, HBASE-7970-v1.patch, HBASE-7970-v2.1.patch,
HBASE-7970-v2.patch, HBASE-7970-v3.patch
>
>
> This is because there are two open calls in the HFile: one with checksum and another
for without checksum support in v2:
> see the method in HFile:createReaderWithEncoding()
> {code}
> FSDataInputStream fsdis = fs.open(path);
> FSDataInputStream fsdisNoFsChecksum = fsdis;
> // If the fs is not an instance of HFileSystem, then create an
> // instance of HFileSystem that wraps over the specified fs.
> // In this case, we will not be able to avoid checksumming inside
> // the filesystem.
> if (!(fs instanceof HFileSystem)) {
>   hfs = new HFileSystem(fs);
> } else {
>   hfs = (HFileSystem)fs;
>   // open a stream to read data without checksum verification in
>   // the filesystem
>   fsdisNoFsChecksum = hfs.getNoChecksumFs().open(path);
> }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message