hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7837) Add new metrics to better monitor recovery process
Date Fri, 12 Apr 2013 18:38:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630459#comment-13630459
] 

Ted Yu commented on HBASE-7837:
-------------------------------

Did a quick walk through.
{code}
+ * Interface of the source that will export metrics about the region server's HLog.
+ */
+public interface MetricsEditsReplaySource extends BaseSource {
{code}
The javadoc seems a bit general. Please mention replay.
{code}
+   * @return
    * @throws InterruptedException
    * @throws IOException
    * @throws KeeperException
-   * @return True if meta is healthy, assigned
    */
-  boolean assignMeta(MonitoredTask status)
-  throws InterruptedException, IOException, KeeperException {
+  private void assignMeta(MonitoredTask status)
{code}
Is @return needed now that assignMeta()'s return type is void ?


                
> Add new metrics to better monitor recovery process 
> ---------------------------------------------------
>
>                 Key: HBASE-7837
>                 URL: https://issues.apache.org/jira/browse/HBASE-7837
>             Project: HBase
>          Issue Type: Sub-task
>          Components: metrics
>            Reporter: Jeffrey Zhong
>             Fix For: 0.95.1
>
>         Attachments: hbase-7837-combined.patch, hbase-7837.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message