hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
Date Wed, 10 Apr 2013 06:36:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627536#comment-13627536
] 

Hudson commented on HBASE-7791:
-------------------------------

Integrated in HBase-TRUNK #4048 (See [https://builds.apache.org/job/HBase-TRUNK/4048/])
    HBASE-7791 Compaction USER_PRIORITY is slightly broken (Revision 1466267)

     Result = FAILURE
sershe : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java

                
> Compaction USER_PRIORITY is slightly broken
> -------------------------------------------
>
>                 Key: HBASE-7791
>                 URL: https://issues.apache.org/jira/browse/HBASE-7791
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>         Attachments: HBASE-7791-v0.patch, HBASE-7791-v1.patch, HBASE-7791-v2.patch
>
>
> The code to get compaction priority is as such:
> {code}   public int getCompactPriority(int priority) {
>      // If this is a user-requested compaction, leave this at the highest priority
>      if(priority == Store.PRIORITY_USER) {
>        return Store.PRIORITY_USER;
>      } else {
>        return this.blockingStoreFileCount - this.storefiles.size();
>      }
>    }
> {code}.
> PRIORITY_USER is 1.
> The priorities are compared as numbers in HRegion, so compactions of blocking stores
will override user priority (probably intended); also, if you have blockingFiles minus one,
your priority is suddenly PRIORITY_USER, which may cause at least this:
>         LOG.debug("Warning, compacting more than " + comConf.getMaxFilesToCompact() +
>             " files because of a user-requested major compaction");
> as well as some misleading logging.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message