hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7704) migration tool that checks presence of HFile V1 files
Date Thu, 04 Apr 2013 18:11:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622599#comment-13622599
] 

Sergey Shelukhin commented on HBASE-7704:
-----------------------------------------

bq. Please use a positive number less than 100 for number of threads
nit: Actually the check allows 100; the default value could be logged from constant.

bq. does not exists:
exist

{code} if (isRegionDir(fs, fsStat.getPath())) {code}
Others will be skipped silently, intended?

{code}  List<Future<Path>> l {code} 
Is it possible to name it differently?

bq.  a hfile v1
"an"? not certain actually, I am not a native speaker either :)
Also, it seems like it would only return the first file, might make sense to qualify ("at
least one HFile ...")?

bq. number of HFileV1.
It's actually the number of regions with such files.

bq.  Path p;
Why does p have to be a field? It's only used in call().

{code} catch (IllegalArgumentException iae) {code}
why IllegalArgumentException in particular?

{code}  throw new IOException("Unknown version for hfile: " + storeFilePath); {code} 
Does this exception have to be thrown? It seems that corrupted files will be added regardless,
and caller will just catch and print it.



                
> migration tool that checks presence of HFile V1 files
> -----------------------------------------------------
>
>                 Key: HBASE-7704
>                 URL: https://issues.apache.org/jira/browse/HBASE-7704
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Himanshu Vashishtha
>            Priority: Blocker
>             Fix For: 0.95.1
>
>         Attachments: HBase-7704-v1.patch
>
>
> Below was Stack's comment from HBASE-7660:
> Regards the migration 'tool', or 'tool' to check for presence of v1 files, I imagine
it as an addition to the hfile tool http://hbase.apache.org/book.html#hfile_tool2 The hfile
tool already takes a bunch of args including printing out meta. We could add an option to
print out version only – or return 1 if version 1 or some such – and then do a bit of
code to just list all hfiles and run this script against each. Could MR it if too many files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message