hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7579) HTableDescriptor equals method fails if results are returned in a different order
Date Tue, 23 Apr 2013 23:37:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639827#comment-13639827
] 

Hudson commented on HBASE-7579:
-------------------------------

Integrated in HBase-TRUNK #4076 (See [https://builds.apache.org/job/HBase-TRUNK/4076/])
    HBASE-7579 HTableDescriptor equals method fails if results are returned in a different
order; REVERT AGAIN -- BROKE BUILD -- REVERT CHANGE MADE TO POM ACCIDENTALLY (Revision 1471136)
HBASE-7579 HTableDescriptor equals method fails if results are returned in a different order;
REVERT AGAIN -- BROKE BUILD (Revision 1471135)
HBASE-7579 HTableDescriptor equals method fails if results are returned in a different order;
REAPPLPY (Revision 1471054)
HBASE-7579 HTableDescriptor equals method fails if results are returned in a different order;
REVERT -- OVERCOMMITTED (Revision 1471053)
HBASE-7579 HTableDescriptor equals method fails if results are returned in a different order
(Revision 1471052)

     Result = SUCCESS
stack : 
Files : 
* /hbase/trunk/pom.xml

stack : 
Files : 
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java
* /hbase/trunk/pom.xml

stack : 
Files : 
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java

stack : 
Files : 
* /hbase/trunk/bin/hbase-daemon.sh
* /hbase/trunk/bin/start-hbase.sh
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java

stack : 
Files : 
* /hbase/trunk/bin/hbase-daemon.sh
* /hbase/trunk/bin/start-hbase.sh
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
* /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java

                
> HTableDescriptor equals method fails if results are returned in a different order
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-7579
>                 URL: https://issues.apache.org/jira/browse/HBASE-7579
>             Project: HBase
>          Issue Type: Bug
>          Components: Admin
>    Affects Versions: 0.94.6, 0.95.0
>            Reporter: Aleksandr Shulman
>            Assignee: Aleksandr Shulman
>            Priority: Minor
>             Fix For: 0.98.0, 0.95.1
>
>         Attachments: HBASE-7579-0.94.patch, HBASE-7579-v1.patch, HBASE-7579-v2.patch,
HBASE-7579-v3.patch, HBASE-7579-v4.patch, HBASE-7579-v5.patch
>
>
> HTableDescriptor's compareTo function compares a set of HColumnDescriptors against another
set of HColumnDescriptors. It iterates through both, relying on the fact that they will be
in the same order.
> In my testing, I may have seen this issue come up, so I decided to fix it.
> It's a straightforward fix. I convert the sets into a hashset for O(1) lookups (at least
in theory), then I check that all items in the first set are found in the second.
> Since the sizes are the same, we know that if all elements showed up in the second set,
then they must be equal.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message