hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicolas Liochon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6870) HTable#coprocessorExec always scan the whole table
Date Tue, 16 Apr 2013 08:15:17 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632652#comment-13632652

Nicolas Liochon commented on HBASE-6870:

Fascinating improvement I would say :-)

Some comments:
- You've reorganized the imports, that will create conflicts when people will merge their
patches ;-]
- There is a parameter, but it's never used useCache with a value set to false. Wouldn't be
better to remove it?
- Just a question: why a LinkedHashMap?
- The method should return the interface (Map) but not the real type.
- Using the Map with a byte[] is brittle imho.
- Does getKeysToRegionsInRange needs to be public?

> HTable#coprocessorExec always scan the whole table 
> ---------------------------------------------------
>                 Key: HBASE-6870
>                 URL: https://issues.apache.org/jira/browse/HBASE-6870
>             Project: HBase
>          Issue Type: Improvement
>          Components: Coprocessors
>    Affects Versions: 0.94.1, 0.95.0, 0.95.2
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>            Priority: Critical
>             Fix For: 0.98.0, 0.95.1
>         Attachments: 6870-v4.txt, HBASE-6870.patch, HBASE-6870-testPerformance.patch,
HBASE-6870v2.patch, HBASE-6870v3.patch, hbase-6870v5.patch
> In current logic, HTable#coprocessorExec always scan the whole table, its efficiency
is low and will affect the Regionserver carrying .META. under large coprocessorExec requests

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message