hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-6603) RegionMetricsStorage.incrNumericMetric is called too often
Date Sun, 07 Apr 2013 04:49:21 GMT

     [ https://issues.apache.org/jira/browse/HBASE-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

stack updated HBASE-6603:

    Fix Version/s:     (was: 0.95.0)

Fix up after bulk move overwrote some 0.94.2 fix versions w/ 0.95.0 (Noticed by Lars Hofhansl)
> RegionMetricsStorage.incrNumericMetric is called too often
> ----------------------------------------------------------
>                 Key: HBASE-6603
>                 URL: https://issues.apache.org/jira/browse/HBASE-6603
>             Project: HBase
>          Issue Type: Bug
>          Components: Performance
>            Reporter: Lars Hofhansl
>            Assignee: M. Chen
>             Fix For: 0.94.2
>         Attachments: 6503-0.96.txt, 6603-0.94.txt
> Running an HBase scan load through the profiler revealed that RegionMetricsStorage.incrNumericMetric
is called way too often.
> It turns out that we make this call for *each* KV in StoreScanner.next(...).
> Incrementing AtomicLong requires expensive memory barriers.
> The observation here is that StoreScanner.next(...) can maintain a simple 
> long in its internal loop and only update the metric upon exit. Thus the AtomicLong is
not updated nearly as often.
> That cuts about 10% runtime from scan only load (I'll quantify this better soon).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message