hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-6579) Unnecessary KV order check in StoreScanner
Date Sun, 07 Apr 2013 04:49:17 GMT

     [ https://issues.apache.org/jira/browse/HBASE-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-6579:
-------------------------

    Fix Version/s:     (was: 0.95.0)
                   0.94.2

Fix up after bulk move overwrote some 0.94.2 fix versions w/ 0.95.0 (Noticed by Lars Hofhansl)
                
> Unnecessary KV order check in StoreScanner
> ------------------------------------------
>
>                 Key: HBASE-6579
>                 URL: https://issues.apache.org/jira/browse/HBASE-6579
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Minor
>             Fix For: 0.94.2
>
>         Attachments: 6579.txt
>
>
> In StoreScanner.next(List<KeyValue>, int, String) I find this code:
> {code}
>       // Check that the heap gives us KVs in an increasing order.
>       if (prevKV != null && comparator != null
>           && comparator.compare(prevKV, kv) > 0) {
>         throw new IOException("Key " + prevKV + " followed by a " +
>             "smaller key " + kv + " in cf " + store);
>       }
>       prevKV = kv;
> {code}
> So this checks for bugs in the HFiles or the scanner code. It needs to compare each KVs
with its predecessor. This seems unnecessary now, I propose that we remove this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message