hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-2231) Compaction events should be written to HLog
Date Thu, 25 Apr 2013 21:50:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642260#comment-13642260
] 

stack commented on HBASE-2231:
------------------------------

bq. I don't know, you tell me  It was in the v4 patch, so I kept it. Let me get rid of it,
we can just use the PB object directly as you said.

I don't remember what I was thinking back then (unsmile).

bq.  I was thinking of adding a new Type in KeyValue, smt like Marker, so that we do not hack
around METAFAMILY. wdyt, I can do a follow up issue.

It is fine as is for now.  If we want more special markers, lets do the special KV type (good
idea btw).

bq. It is not used after HBASE-7329. I should remove it.

Out of scope for this.  New issue?

bq. if WAL disabled or deferred...

What is this?  If either of the above, you are playing w/ fire anyways so you could lose data?

Let me look at new version of patch.




                
> Compaction events should be written to HLog
> -------------------------------------------
>
>                 Key: HBASE-2231
>                 URL: https://issues.apache.org/jira/browse/HBASE-2231
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Todd Lipcon
>            Assignee: stack
>            Priority: Blocker
>              Labels: moved_from_0_20_5
>             Fix For: 0.95.1
>
>         Attachments: 2231-testcase-0.94.txt, 2231-testcase_v2.txt, 2231-testcase_v3.txt,
2231v2.txt, 2231v3.txt, 2231v4.txt, hbase-2231-testcase.txt, hbase-2231.txt, hbase-2231_v5.patch,
hbase-2231_v6.patch, hbase-2231_v7.patch
>
>
> The sequence for a compaction should look like this:
> # Compact region to "new" files
> # Write a "Compacted Region" entry to the HLog
> # Delete "old" files
> This deals with a case where the RS has paused between step 1 and 2 and the regions have
since been reassigned.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message