Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 26 Mar 2013 04:39:16 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12638782.1364191543990.53790.1364272756522@arcas>
In-Reply-To: <JIRA.12638782.1364191543990@arcas>
References: <JIRA.12638782.1364191543990@arcas>
Subject: [jira] [Commented] (HBASE-8192) wrong logic in
 HRegion.bulkLoadHFiles(List)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613485#comment-13613485 ] 

Hadoop QA commented on HBASE-8192:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12575461/8192.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:red}-1 site{color}.  The patch appears to cause mvn site goal to fail.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.wal.TestHLog
                  org.apache.hadoop.hbase.io.encoding.TestChangingEncoding

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5013//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5013//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5013//console

This message is automatically generated.
                
> wrong logic in HRegion.bulkLoadHFiles(List)
> -------------------------------------------
>
>                 Key: HBASE-8192
>                 URL: https://issues.apache.org/jira/browse/HBASE-8192
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.94.1, 0.94.2, 0.94.3, 0.94.4, 0.94.5
>            Reporter: Chenghao Jiang
>              Labels: patch
>             Fix For: 0.94.7
>
>         Attachments: 8192.txt
>
>
> the wrong logic is here:
>   when a ColumnFamily does not exist, it gets a null store object, then ioes.add(ioe); failures.add(p)
>   but the code below, if (failures.size() != 0), it prints a warn log and return false, so it will never go into the code if (ioes.size() != 0) below, and IOException will not be thrown, then the client will keep retry forever.
>   there is the same situation when doing store.assertBulkLoadHFileOk, if any WrongRegionException is caught and failures.add(p), then all the other IOException thrown by assertBulkLoadHFileOk will be ignored.
>   so i think if (failures.size() != 0) {} should be dealt with after if (ioes.size() !=0) {}
> {code}
> for (Pair<byte[], String> p : familyPaths) {
>     byte[] familyName = p.getFirst();
>     String path = p.getSecond();
>     Store store = getStore(familyName);
>     if (store == null) {
>         IOException ioe = new DoNotRetryIOException(
>                 "No such column family " + Bytes.toStringBinary(familyName));
>         ioes.add(ioe);
>         failures.add(p);
>     } else {
>         try {
>             store.assertBulkLoadHFileOk(new Path(path));
>         } catch (WrongRegionException wre) {
>             // recoverable (file doesn't fit in region)
>             failures.add(p);
>         } catch (IOException ioe) {
>             // unrecoverable (hdfs problem)
>             ioes.add(ioe);
>         }
>     }
> }
> // validation failed, bail out before doing anything permanent.
> if (failures.size() != 0) {
>     StringBuilder list = new StringBuilder();
>     for (Pair<byte[], String> p : failures) {
>         list.append("\n").append(Bytes.toString(p.getFirst())).append(" : ")
>             .append(p.getSecond());
>     }
>     // problem when validating
>     LOG.warn("There was a recoverable bulk load failure likely due to a" +
>             " split.  These (family, HFile) pairs were not loaded: " + list);
>     return false;
> }
> // validation failed because of some sort of IO problem.
> if (ioes.size() != 0) {
>     LOG.error("There were IO errors when checking if bulk load is ok.  " +
>             "throwing exception!");
>     throw MultipleIOException.createIOException(ioes);
> }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira