Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B971FD0DB for ; Tue, 19 Mar 2013 08:25:18 +0000 (UTC) Received: (qmail 82786 invoked by uid 500); 19 Mar 2013 08:25:18 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 82754 invoked by uid 500); 19 Mar 2013 08:25:18 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 82743 invoked by uid 99); 19 Mar 2013 08:25:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Mar 2013 08:25:18 +0000 Date: Tue, 19 Mar 2013 08:25:18 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8128) HTable#put improvements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606166#comment-13606166 ] Hudson commented on HBASE-8128: ------------------------------- Integrated in HBase-0.94-security #127 (See [https://builds.apache.org/job/HBase-0.94-security/127/]) HBASE-8128 HTable#put improvements (Revision 1457939) Result = FAILURE nkeywal : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTable.java > HTable#put improvements > ----------------------- > > Key: HBASE-8128 > URL: https://issues.apache.org/jira/browse/HBASE-8128 > Project: HBase > Issue Type: Bug > Components: Client > Affects Versions: 0.95.0, 0.96.0 > Reporter: nkeywal > Assignee: nkeywal > Priority: Trivial > Fix For: 0.95.0, 0.96.0, 0.94.7 > > Attachments: 8128.v1.patch > > > 3 points: > - When doing a single put, we're creating an object by calling Arrays.asList > - we're doing a size check every 10 put. Not doing it seems simpler, better and allows to share some code between a single put and a list of puts. > - we could call flushCommits on empty write buffer, especially for someone using a lot of HTable instead of using a pool, as it's called in close(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira