Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9212AEAC0 for ; Sun, 17 Mar 2013 04:12:14 +0000 (UTC) Received: (qmail 42593 invoked by uid 500); 17 Mar 2013 04:12:14 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 42319 invoked by uid 500); 17 Mar 2013 04:12:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 42283 invoked by uid 99); 17 Mar 2013 04:12:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 17 Mar 2013 04:12:12 +0000 Date: Sun, 17 Mar 2013 04:12:12 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8125) HBASE-7435 breaks BuiltInGzipDecompressor on Hadoop < 1.0.x MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604502#comment-13604502 ] Ted Yu commented on HBASE-8125: ------------------------------- Integrated to 0.94 Thanks for the review, Lars. This is not needed for 0.95 or higher version. > HBASE-7435 breaks BuiltInGzipDecompressor on Hadoop < 1.0.x > ----------------------------------------------------------- > > Key: HBASE-8125 > URL: https://issues.apache.org/jira/browse/HBASE-8125 > Project: HBase > Issue Type: Bug > Reporter: stack > Assignee: Ted Yu > Fix For: 0.94.7 > > Attachments: 8125-0.94.txt > > > From some friends of ours at dropbox: > Index: src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java > =================================================================== > --- src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java (revision 1425723) > +++ src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java (working copy) > @@ -33,6 +33,7 @@ > import org.apache.hadoop.io.compress.CompressionOutputStream; > import org.apache.hadoop.io.compress.Compressor; > import org.apache.hadoop.io.compress.Decompressor; > +import org.apache.hadoop.io.compress.DoNotPool; > import org.apache.hadoop.io.compress.GzipCodec; > import org.apache.hadoop.io.compress.DefaultCodec; > import org.apache.hadoop.util.ReflectionUtils; > @@ -308,6 +309,9 @@ > public void returnDecompressor(Decompressor decompressor) { > if (decompressor != null) { > CodecPool.returnDecompressor(decompressor); > + if (decompressor.getClass().isAnnotationPresent(DoNotPool.class)) { > + decompressor.end(); > + } > } > } > breaks compatibility with hadoop-0.20.2-cdh3u2. > +import org.apache.hadoop.io.compress.DoNotPool; > does not exist in that version of hadoop. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira