Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A042DED1 for ; Wed, 13 Mar 2013 23:22:13 +0000 (UTC) Received: (qmail 73015 invoked by uid 500); 13 Mar 2013 23:22:12 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 72940 invoked by uid 500); 13 Mar 2013 23:22:12 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 72928 invoked by uid 99); 13 Mar 2013 23:22:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Mar 2013 23:22:12 +0000 Date: Wed, 13 Mar 2013 23:22:12 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8094) TestTableInputFormatScan doesn't assert anything MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601796#comment-13601796 ] Ted Yu commented on HBASE-8094: ------------------------------- You're right, Nick. The warnings came from HBASE-8066 > TestTableInputFormatScan doesn't assert anything > ------------------------------------------------ > > Key: HBASE-8094 > URL: https://issues.apache.org/jira/browse/HBASE-8094 > Project: HBase > Issue Type: Sub-task > Components: mapreduce, test > Reporter: Nick Dimiduk > Assignee: Nick Dimiduk > Fix For: 0.95.0, 0.98.0 > > Attachments: 0001-HBASE-8094-fix-broken-TestTableInputFormatScan.patch > > > This test makes assertions from within the Reducer. These tests are not respected because the control harness asserts only that jobs complete, not that they succeed. > Verify this is true by adding a failure to the reducer: > {noformat} > $ git diff > diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java > index bab9633..322cb4f 100644 > --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java > +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormatScan.java > @@ -160,6 +160,7 @@ public class TestTableInputFormatScan { > if (lastRow != null && lastRow.length() > 0) { > assertEquals(lastRow, last); > } > + assertTrue(false); > } > > } > {noformat} > The test still passes. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira