Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 574799314 for ; Fri, 8 Mar 2013 18:18:14 +0000 (UTC) Received: (qmail 39675 invoked by uid 500); 8 Mar 2013 18:18:14 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 39635 invoked by uid 500); 8 Mar 2013 18:18:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 39626 invoked by uid 99); 8 Mar 2013 18:18:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Mar 2013 18:18:13 +0000 Date: Fri, 8 Mar 2013 18:18:13 +0000 (UTC) From: "Nick Dimiduk (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8034) record on-disk data size for store file and make it available during writing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597369#comment-13597369 ] Nick Dimiduk commented on HBASE-8034: ------------------------------------- Would it make more sense to expose the number of KeyValues in the HFile? {code} + @Override + public long getCurrentSize() throws IOException { + if (this.outputStream == null) return -1; + return this.outputStream.getPos(); + } {code} This strikes me as flakey. Will there be another thread writing to the OutputStream when this method is invoked? Should it be synchronized? > record on-disk data size for store file and make it available during writing > ---------------------------------------------------------------------------- > > Key: HBASE-8034 > URL: https://issues.apache.org/jira/browse/HBASE-8034 > Project: HBase > Issue Type: Task > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Priority: Minor > Attachments: HBASE-8034-v0.patch > > > To better estimate the size of data in the file, and to be able to split files intelligently during any multi-file compactor like stripe or level. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira