Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8A5B0DB1D for ; Tue, 5 Mar 2013 17:18:19 +0000 (UTC) Received: (qmail 96516 invoked by uid 500); 5 Mar 2013 17:18:19 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 95263 invoked by uid 500); 5 Mar 2013 17:18:14 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 95197 invoked by uid 99); 5 Mar 2013 17:18:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Mar 2013 17:18:13 +0000 Date: Tue, 5 Mar 2013 17:18:13 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-8006) use FSUtils to get/set hbase.rootdir MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-8006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593605#comment-13593605 ] stack commented on HBASE-8006: ------------------------------ [~mbertozzi] I am keeping an eye on them. I see the above pattern emerge in hadoopqa builds. Will dig in. Am not seeing it on private jenkins build of 0.95. +1 on patch. Nice cleanup. There is stuff out in .rb scripts that does this but can do separately (The .rbs need a purge anyways). > use FSUtils to get/set hbase.rootdir > ------------------------------------ > > Key: HBASE-8006 > URL: https://issues.apache.org/jira/browse/HBASE-8006 > Project: HBase > Issue Type: Sub-task > Components: regionserver > Reporter: Matteo Bertozzi > Assignee: Matteo Bertozzi > Priority: Minor > Labels: noob > Attachments: HBASE-8006-v0.patch > > > We have different ways around the code to get the root dir > {code} > this.conf.get("hbase.rootdir") > new Path(conf.get(HConstants.HBASE_DIR)); > fs.makeQualified(new Path(this.c.get(HConstants.HBASE_DIR))); > FSUtils.getRootDir(conf) > {code} > also we have lots of places where we have this set fs.default > {code} > this.conf.set("fs.default.name", fs.getUri().toString()); > this.conf.set("fs.defaultFS", fs.getUri().toString()); > {code} > replace everything to use the FSUtils and have one single way to do this stuff -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira