Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 6 Mar 2013 00:00:13 +0000 (UTC)
From: "Sergey Shelukhin (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12634024.1361836291510.387584.1362528013594@arcas>
In-Reply-To: <JIRA.12634024.1361836291510@arcas>
References: <JIRA.12634024.1361836291510@arcas>
Subject: [jira] [Commented] (HBASE-7935) make policy and compactor in
 default store engine separately pluggable (for things like tier-based, and
 default policy experiments with permutations)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594120#comment-13594120 ] 

Sergey Shelukhin commented on HBASE-7935:
-----------------------------------------

bq. 2. Do you want to retain the existing signature for createComponents and instead have the method throw RuntimeException (which doesn't need to be declared).
Probably not, the only reason it was called like that to not call abstract method in ctor. Given that store engine is always created  via create it should be ok to have a method to initialize.
bq. 4. I am confused by the "isInitialized" field in the StoreEngine.java that you removed in the patch. Why was that required earlier and not required now?
Previously the init was called on first use, so it was needed to tell the first use apart; now it's called in a well defined place at create time.
                
> make policy and compactor in default store engine separately pluggable (for things like tier-based, and default policy experiments with permutations)
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7935
>                 URL: https://issues.apache.org/jira/browse/HBASE-7935
>             Project: HBase
>          Issue Type: Improvement
>          Components: Compaction
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>         Attachments: HBASE-7935-v0.patch, HBASE-7935-v0-with-7843.patch, HBASE-7935-v1.patch, HBASE-7935-v2.patch
>
>
> Technically, StoreEngine can be used to achieve any permutations of things, but to make it more convenient to replace compaction policy/compator in standard schemes like tier-based, we can add separate hooks in DefaultStoreEngine (as long as custom ones conform to its default expectations e.g. flat list of sorted files, etc.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira