Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 61719D86A for ; Tue, 19 Mar 2013 01:51:19 +0000 (UTC) Received: (qmail 74365 invoked by uid 500); 19 Mar 2013 01:51:17 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 74297 invoked by uid 500); 19 Mar 2013 01:51:17 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 74209 invoked by uid 99); 19 Mar 2013 01:51:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Mar 2013 01:51:16 +0000 Date: Tue, 19 Mar 2013 01:51:16 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-7878) recoverFileLease does not check return value of recoverLease MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-7878: -------------------------- Attachment: (was: 7878-trunk-v10.txt) > recoverFileLease does not check return value of recoverLease > ------------------------------------------------------------ > > Key: HBASE-7878 > URL: https://issues.apache.org/jira/browse/HBASE-7878 > Project: HBase > Issue Type: Bug > Components: util > Affects Versions: 0.95.0, 0.94.6 > Reporter: Eric Newton > Assignee: Ted Yu > Priority: Critical > Fix For: 0.95.0, 0.98.0, 0.94.7 > > Attachments: 7878.94, 7878-94.addendum, 7878-94.addendum2, 7878-trunk.addendum, 7878-trunk.addendum2, 7878-trunk-v10.txt, 7878-trunk-v2.txt, 7878-trunk-v3.txt, 7878-trunk-v4.txt, 7878-trunk-v5.txt, 7878-trunk-v6.txt, 7878-trunk-v7.txt, 7878-trunk-v8.txt, 7878-trunk-v9.txt, 7878-trunk-v9.txt > > > I think this is a problem, so I'm opening a ticket so an HBase person takes a look. > Apache Accumulo has moved its write-ahead log to HDFS. I modeled the lease recovery for Accumulo after HBase's lease recovery. During testing, we experienced data loss. I found it is necessary to wait until recoverLease returns true to know that the file has been truly closed. In FSHDFSUtils, the return result of recoverLease is not checked. In the unit tests created to check lease recovery in HBASE-2645, the return result of recoverLease is always checked. > I think FSHDFSUtils should be modified to check the return result, and wait until it returns true. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira