Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9A04ED20B for ; Wed, 13 Mar 2013 04:44:16 +0000 (UTC) Received: (qmail 60512 invoked by uid 500); 13 Mar 2013 04:44:16 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 60414 invoked by uid 500); 13 Mar 2013 04:44:16 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 60375 invoked by uid 99); 13 Mar 2013 04:44:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Mar 2013 04:44:15 +0000 Date: Wed, 13 Mar 2013 04:44:14 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-7596) Redundant FSTableDescriptor update MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600813#comment-13600813 ] Hudson commented on HBASE-7596: ------------------------------- Integrated in HBase-0.94-security #121 (See [https://builds.apache.org/job/HBase-0.94-security/121/]) HBASE-7624 Backport HBASE-5359 and HBASE-7596 to 0.94 (Jefferey Zhong) (Revision 1455730) Result = FAILURE tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler/TestTableDescriptorModification.java > Redundant FSTableDescriptor update > ---------------------------------- > > Key: HBASE-7596 > URL: https://issues.apache.org/jira/browse/HBASE-7596 > Project: HBase > Issue Type: Bug > Components: master > Affects Versions: 0.96.0, 0.94.4 > Reporter: Matteo Bertozzi > Assignee: Matteo Bertozzi > Priority: Trivial > Fix For: 0.95.0 > > Attachments: HBASE-7596-v0.patch > > > The TableAddFamilyHandler and TableDeleteFamilyHandler code looks like > {code} > // Update table descriptor in HDFS > HTableDescriptor htd = this.masterServices.getMasterFileSystem() > .addColumn(tableName, familyDesc); > // Update in-memory descriptor cache > this.masterServices.getTableDescriptors().add(htd); > {code} > while the ModifyTableHandler code is just > {code} > // Update descriptor > this.masterServices.getTableDescriptors().add(this.htd); > {code} > The MasterFileSystem code looks like > {code} > HTableDescriptor htd = this.services.getTableDescriptors().get(tableName); > // ...add/remove columns to the descriptor... > this.services.getTableDescriptors().add(htd); > {code} > so, the service.getTableDescriptors().add() is called two times for the add/delete family handler. (and the table descriptor rewritten twice FSTableDescriptors.updateHTableDescriptor()) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira